search

justbetter / magento2-sentry

Magento 2 module to log to Sentry
MIT License
165 stars 70 forks source link

fix overriding configuration #144

Open rommelfreddy opened 4 months ago

rommelfreddy commented 4 months ago

This fixes an issue that if you save the configuration within the administration, the sentry error reporting got disabled, because of the setting sentry/environment/enabled

this PR will add another setting with which it is possible to enable to override. Only if the override is enabled, it is possible to disable the Sentry error tracking.

Also reworked the collectModuleConfig within the config-helper to make sure that values, which are null or empty, do not override the deployment configuration.

I added canRestore to the system.xml to make sure that no empty values got stored into the database.

I removed the TableNotFoundException-Handling, because i do not see a case when this could happen.

indykoning commented 3 months ago

Awesome i can't wait to get this merged!

The TableNotFoundException had been introduced in https://github.com/justbetter/magento2-sentry/pull/125 I could personally reproduce this in the few cases of setting up the project with sentry already installed, or in deployment pipelines where the code would be built but no database connection could be available.

Could you try the steps in that PR and see if it is no longer an issue with your current code? 🙂