search

justbuchanan / occt_bazel

A command-line program for generating Bazel BUILD files for OpenCascade/OCCT
3 stars 0 forks source link

Non-standard headers in StepFile src directory #1

Open brawner opened 3 years ago

brawner commented 3 years ago

This is a really great tool you've created. I noticed when trying to use it though that there are a few weird header extensions in the StepFile directory. Notably: location.hh, recfile.pc, stepread.ph, and recfile.ph. I don't see any other files elsewhere with these sorts of extensions. It might just be a weird one-off situation.

For myself, I just manually added those extensions to the StepFile target.

brawner commented 3 years ago

Err, this is an issue because they don't match the extensions in the bazel.go file:

https://github.com/justbuchanan/occt_bazel/blob/c8fc0d94785d3c7d203b8179906ea5cadab137df/bazel.go#L162-L166

justbuchanan commented 3 years ago

Thanks, glad you found this useful. I think the easiest fix would be to just add those entries to the code you linked to in bazel.go. OCCT uses a lot of weird extensions, so I'm not surprised that list is incomplete :).

justbuchanan commented 3 years ago

To clarify, did manually adding those extensions to the StepFile target fix things?

brawner commented 3 years ago

It worked for my build on Ubuntu, I'm still having to work things out on OSX though. There are some objective-c files (.mm) in there.

justbuchanan commented 3 years ago

Ahh that makes sense, I haven't tried to build this on OSX yet. It'd be great if this worked on OSX though, so let me know if you're able to get it to build.

brawner commented 3 years ago

I actually did get it to work on OSX and Ubuntu. It's not yet ready to make a PR back here, but the OSX dependencies can be installed with homebrew.