search

justbur / emacs-which-key

Emacs package that displays available keybindings in popup
GNU General Public License v3.0
1.74k stars 87 forks source link

Ignore keybinding not working anymore? #257

Closed TheBlob42 closed 4 years ago

TheBlob42 commented 4 years ago

In the documentation of which-key-replacement-alist it states:

If REPLACEMENT is anything other than a cons cell (and non nil) the key binding is ignored by which-key.

which I use to ignore my winum keybindings and instead replace them with a single which key entry like so:

(push '((nil . "winum-select-window-[1-9]") . t)
    which-key-replacement-alist)

Since the last update to version "20200721.1927" the ignoring does not work for me anymore :crying_cat_face: I am still able to replace the description of those commands:

(push '((nil . "winum-select-window-[1-9]") . (nil . "Something"))
    which-key-replacement-alist)

Is this a bug which was introduced recently or am I missing something which has changed in one of the recent updates? :thinking:

justbur commented 4 years ago

@rgrinberg any chance your change caused this?

rgrinberg commented 4 years ago

I'll have a look

jkroes commented 4 years ago

I'm experiencing the same issue as @TheBlob42 since upgrading my version of which-package on one of two operating systems. The older Melpa version, which-key-20200702.219, works. The version with the issue is which-key-20200721.2156. So one of the last two commits?

rgrinberg commented 4 years ago

Sorry for taking a while on this. #258 should fix this.