justbur / emacs-which-key

Emacs package that displays available keybindings in popup
GNU General Public License v3.0
1.74k stars 87 forks source link

Fix #257 #258

Closed rgrinberg closed 4 years ago

rgrinberg commented 4 years ago

Explicitly distinguish between replacing with nil and not replacing at all.

I'm also simplifying the code by making all the branches more explicit. This is a little longer, but makes all the clauses obvious.

rgrinberg commented 4 years ago

Hmm, there's a failure on 24.5. I don't really understand why.

justbur commented 4 years ago

Thanks. I'm not worried about the 24.5 failure.

I'd like to overhaul this replacement stuff anyway. I just don't have any free time right now.