search

justbur / emacs-which-key

Emacs package that displays available keybindings in popup
GNU General Public License v3.0
1.74k stars 87 forks source link

which-key setup in the readme leads to error #297

Closed iyefrat closed 3 years ago

iyefrat commented 3 years ago

when opening emacs -Q and evaling the following:

(require 'package)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)
(package-initialize)
(package-refresh-contents)
(package-install 'embark)
(require 'embark)
(global-set-key (kbd "C-S-a") #'embark-act)

(package-install 'which-key)
(require 'which-key)
(which-key-mode)
(setq embark-action-indicator
      (lambda (map _target)
        (which-key--show-keymap "Embark" map nil nil 'no-paging)
        #'which-key--hide-popup-ignore-command)
      embark-become-indicator embark-action-indicator)

then trying to do embark-become on say M-x leads to the following error:

Debugger entered--Lisp error: (wrong-number-of-arguments (lambda (map _target) (which-key--show-keymap "Embark" map nil nil 'no-paging) #'which-key--hide-popup-ignore-command) 1)
  (lambda (map _target) (which-key--show-keymap "Embark" map nil nil 'no-paging) #'which-key--hide-popup-ignore-command)((keymap keymap (8 . embark-keymap-help)))
  embark--show-indicator((lambda (map _target) (which-key--show-keymap "Embark" map nil nil 'no-paging) #'which-key--hide-popup-ignore-command) (keymap keymap (8 . embark-keymap-help)) nil)
  embark--with-indicator((lambda (map _target) (which-key--show-keymap "Embark" map nil nil 'no-paging) #'which-key--hide-popup-ignore-command) embark-keymap-prompter (keymap keymap (8 . embark-keymap-help)))
  embark-become(nil)
  funcall-interactively(embark-become nil)
  command-execute(embark-become)
  embark--act(embark-become #("eval-buffer" 0 5 (face (completions-common-part)) 5 6 (face (completions-first-difference))) t)
  embark-act(nil)
  funcall-interactively(embark-act nil)
  command-execute(embark-act)
  completing-read-default("M-x " #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_46> #f(compiled-function (sym) #<bytecode -0x13d46ac39eaa5be8>) t nil extended-command-history nil nil)
  read-extended-command()
  byte-code("\302\30\11\303 \10E)\207" [execute-extended-command--last-typed current-prefix-arg nil read-extended-command] 3)
  command-execute(execute-extended-command)

However from looking around the source code it seems that two arguments is indeed the correct number so I'm not sure what I'm missing. cc @Zetagon

iyefrat commented 3 years ago

oh i accidentally typed all of this in the wrong tab, apologies for the inconvenience.