How to modify the config to silent the user warning?

justbur / emacs-which-key

Emacs package that displays available keybindings in popup

GNU General Public License v3.0

1.74k stars 87 forks source link

How to modify the config to silent the user warning? #310

Closed et2010 closed 3 years ago

et2010 commented 3 years ago

The recent update of which key leads to user warning at startup of the spacemacs. I found it's caused by those configurations:

https://github.com/syl20bnr/spacemacs/blob/443311c8f1d7c6ebbe1d10be576a4edc47e03a5a/layers/%2Bsource-control/git/packages.el#L275

I'm not sure what those lines were supposed to do and how to modify those lines without breaking spacemacs. Can you recommend a fix for the above lines in order to silent the warning? Thank you in advance!

@justbur

justbur commented 3 years ago

That's an incorrect usage of that function. It will need to be fixed in spacemacs

duianto commented 3 years ago

A Spacemacs PR has been merged that reverted the incorrect usage. Revert "Fix which-key entries: gr and gs in dired and magit" https://github.com/syl20bnr/spacemacs/pull/14869

A recent which-key update seems to have made that fix obsolete. The correct which-key entries still appear as expected when the fix is reverted.

et2010 commented 3 years ago

Thank you! After updating spacemacs, the issue was gone!