search

justbur / emacs-which-key

Emacs package that displays available keybindings in popup
GNU General Public License v3.0
1.74k stars 87 forks source link

New compiler warnings #312

Closed tarsius closed 3 years ago

tarsius commented 3 years ago

Recent changes resulted in these new compiler warnings:

Compiling /home/jonas/.emacs.d/lib/which-key/which-key.el...

In which-key--safe-lookup-key:
lib/which-key/which-key.el:1443:11: Warning: defsubst
    ‘which-key--safe-lookup-key’ was used before it was defined

In which-key--format-and-replace:
lib/which-key/which-key.el:1705:68: Warning: Unused lexical argument `prefix'

In which-key--get-keymap-bindings:
lib/which-key/which-key.el:1821:57: Warning: reference to free variable
    ‘evil-state’

I am guessing the second one is actually a bug, but you are in a better position to quickly determine that, so no commits from me this time.

(May I interest you in my auto-compile package? If you used that it would become less likely that you overlooked such problems.)

justbur commented 3 years ago

Thanks, see 27d9fec

(May I interest you in my auto-compile package? If you used that it would become less likely that you overlooked such problems.)

I have it and use it :), but I didn't have a compiled version of the file in the directory so it wasn't doing anything.

tarsius commented 3 years ago

Ups :grinning: