search

justbur / emacs-which-key

Emacs package that displays available keybindings in popup
GNU General Public License v3.0
1.74k stars 87 forks source link

Possible wrong parameters passed to which-key--get-keymap-bindings #322

Closed Zetagon closed 3 years ago

Zetagon commented 3 years ago

This might just be confusing naming, but the filter variable in which-key--get-bindings doesn't get passed as the filter parameter to which-key--get-keymap-bindings. It would be an off-by-one error. https://github.com/justbur/emacs-which-key/blob/27d9fec33abb989b030f7677ccf5f799287d6472/which-key.el#L1847-L1848

I'm suspecting it should be the code below instead, with start set to nil.

(which-key--get-keymap-bindings
                  keymap nil prefix filter recursive)