justbur / emacs-which-key

Emacs package that displays available keybindings in popup
GNU General Public License v3.0
1.73k stars 87 forks source link

Improve paging hint #370

Open crzcrz opened 4 months ago

crzcrz commented 4 months ago

This PR attempts to improve the paging hint displayed when all key bindings do not fit on the screen.

This should improve the experience for newcomers a bit.

Tested under clean Emacs 29.3 and Doom v3.0.0-pre from yesterday.

When testing today I've noticed that C-h C-h now works under Doom and displays the paging prompt, while it certainly did not when I submitted #368, and it still does not in "clean" Emacs. However in the original implementation we would not display any paging hint at all, so I don't think we are making anything worse.

Closes #368

justbur commented 4 months ago

Thanks. Sorry for not asking earlier, but have you assigned your copyright to the FSF (see here)?

crzcrz commented 3 months ago

It’s in progress.

justbur commented 2 months ago

Hi @crzcrz, I'm not sure what the status is on this, but I'm planning to archive this repo as which-key was recently merged into the master branch of emacs. Contributions can now be considered through the standard emacs channels.