search

justbur / emacs-which-key

Emacs package that displays available keybindings in popup
GNU General Public License v3.0
1.73k stars 87 forks source link

Symbolize special keys #372

Closed pradyparanjpe closed 2 months ago

pradyparanjpe commented 4 months ago

Use user-assigned symbols (strings) to represent special keys. If value of which-key-special-keys is an alist of cons cells, whose cars are special keys such as SPC, TAB, ... and the cdrs are symbol strings, replace the special keys with corresponding symbols.

For backward-compatibility, if which-key-special-keys is an ordinary list of keys, old logic of trucation to single character works.

pradyparanjpe commented 4 months ago

I don't know if this feature edit is worth copyright transfer. I haven't done such an activity before. I am (obviously) ready to transfer copyright for the edit if necessary.

EDIT: I have sent the request form anyway; don't know what follows.

justbur commented 4 months ago

I believe it will require the copyright transfer given its size, so I will wait to merge it.

By the way, at least part of this is possible now by specifying a replacement string for the key using which-key-replacement-alist. Is it that you want the special key face to apply too?

pradyparanjpe commented 2 months ago

I believe it will require the copyright transfer given its size, so I will wait to merge it.

I got the request form only recently (a few days ago), signed and mailed it back, no reply from GNU FSF since...

justbur commented 2 months ago

It can take a while yes. Let me know when you are notified

pradyparanjpe commented 2 months ago

By the way, at least part of this is possible now by specifying a replacement string for the key using which-key-replacement-alist. Is it that you want the special key face to apply too?

Yes, to be treated along with 'special'.

It can take a while yes. Let me know when you are notified

Got back a mail from FSF with the PDF counter-signed accepted.

How should I share the PDF with you?

justbur commented 2 months ago

Great!

There's been a new development in the meantime. which-key was merged into emacs proper. As a result, I am planning to archive this repository and start taking contributions like yours through the standard emacs channels. There are actually two versions of which-key at the moment, the one here and the one that just got merged into the master branch of emacs.

If possible, would you mind submitting this patch as a bug report to emacs?

pradyparanjpe commented 2 months ago

I've never done that before, but I'll try.

justbur commented 2 months ago

Thank you.

On Fri, Jun 21, 2024 at 10:24 AM Pradyumna Paranjape < @.***> wrote:

I've never done that before, but I'll try.

— Reply to this email directly, view it on GitHub https://github.com/justbur/emacs-which-key/pull/372#issuecomment-2182856244, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ3E7VAJYW4ZTBBUCK52N3ZIQZR3AVCNFSM6AAAAABGJO3HGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSHA2TMMRUGQ . You are receiving this because you commented.Message ID: @.***>