merge binge and single, exit on completion

[Ar4m1s]

Still can't test for manga. Does manga not work or is it just me? For the cases that are one line, should I join them like this?

"Watch Anime") binge "ANIME" ;;

Closes #22 Closes #29

[justchokingaround]

yes

[justchokingaround]

got manga to work again, i will test this PR more extensively in a few days

[Ar4m1s]

You are aware that the second commit makes total episodes in the anime_list off by one if it is currently releasing.

[justchokingaround]

no i'm not, thats a choke on my part :sob:, can u revert it pretty please?

[Ar4m1s]

It fixes more than it breaks tho.

[Ar4m1s]

Previously there was a question mark instead. And it is correct after you have selected episode using no anilist.

[justchokingaround]

oh

[Ar4m1s]

You can't really do math with regex so there is no simple fix.

[Ar4m1s]

The off by one is why I marked the commit OBO

[Ar4m1s]

The second commit was essentially trying to solve the issue that I referenced when asking for help on discord. The issue was later deleted for some reason.

[justchokingaround]

when a user watches an episode, then quits the player mid episode (before 85%, so before completing the whole episode), and presses yes to keep watching, it goes to the next episode even tho it should keep playing the same episode from the same position

[Ar4m1s]

Is there a way to see if the episode has been watched 85% or more? If so, it would be an easy fix.

[justchokingaround]

https://github.com/justchokingaround/jerry/blob/main/jerry.sh#L1066 that's what this variable is used for ^^^

example usage: https://github.com/justchokingaround/jerry/blob/main/jerry.sh#L986

[Ar4m1s]

Yes, I just found it.

[Ar4m1s]

What should it do if you quit early?

[justchokingaround]

not update progress to progress + 1

[justchokingaround]

also, the episodes releasing thing doesn't show up for the user list, it's only used when a user looks up an anime:

if u don't have an anilist account, i can implement this later

[Ar4m1s]

It happens because I did not update the get_anime_from_list function.

[Ar4m1s]

The episode numbers are fixed. Should I add (releasing) to the shows that are?

[justchokingaround]

yes please, it looks nice

[Ar4m1s]

Should it be at the end or after the episode number?

[justchokingaround]

after ep number, in ()

[Ar4m1s]

I added the (releasing) and if are dissatisfied with the placement just tell me. It is easy to change.

[justchokingaround]

yep, thx, ill check

[justchokingaround]

can you just add a space between episodes and (releasing) please? otherwise it looks great, its a good addition

[Ar4m1s]

changed it.(in both functions)

[Ar4m1s]

Added fix for issue: #29 .