justchokingaround / jerry

watch anime with automatic anilist syncing and other cool stuff
GNU General Public License v3.0
291 stars 20 forks source link

Follow convention for yes/no questions #29

Closed Ar4m1s closed 1 year ago

Ar4m1s commented 1 year ago

Shouldn't line 164 be switched out to be consistent with convention? I made yes default since it is capitalized instead of no. If you don't want yes to be default the n should be capitalized instead.

Example of how it could be fixed if yes is the default:

printf "No configuration file found. Would you like to generate a default one? [Y/n] " && read -r generate
case "$generate" in
"No" | "no" | "n" | "N") exit 0 ;;
justchokingaround commented 1 year ago

yes should be the default. i forgot to implement it

Ar4m1s commented 1 year ago

Added in the PR

justchokingaround commented 1 year ago

tyyy :)