justchokingaround / jerry

watch anime with automatic anilist syncing and other cool stuff
GNU General Public License v3.0
291 stars 20 forks source link

Use IINA instead of MPV #5

Closed allusive-dev closed 7 months ago

allusive-dev commented 1 year ago

So i dont like using mpv, is there a way I can use VLC to watch animes instead?

justchokingaround commented 1 year ago

sure, but that'll affect other features such as resume from history. i'll trybto implement something later this week

Poloniumx86 commented 1 year ago

And iina for macos, much better ui + ani-cli uses it <3

justchokingaround commented 1 year ago

iina isn't supported on linux since it's written in swift. if there is a way to extract current progress in a video being played by it, i will look into implementing it

allusive-dev commented 1 year ago

Lol this issue is still active

allusive-dev commented 1 year ago

Since i created this issue i have just kept using MPV without any issues so @justchokingaround if you don't feel like making it work for VLC then I'm not too worried anymore.

justchokingaround commented 1 year ago

i'm not entirely against the idea of adding vlc support, the main problem is that the way the history feature is currently implemented, relies on the fact that you can extract the current progress of the currently playing video, which is not possible to do using vlc (afaik)

justchokingaround commented 1 year ago

it seems like it won't be possible to implement history tracking with iina using stderr information, however it is doable using mpv's ipc socket, which should be good enough i think. here is a reference that can be used for this implementation: https://github.com/justchokingaround/lobster/blob/72b5752df1251d33c12a7f81627d1d20413be819/lobster.sh#L293-L319

sneazy-ibo commented 8 months ago

so is this going to be implemented or not?

justchokingaround commented 8 months ago

ongoing issue

justchokingaround commented 7 months ago

done in 9238e6e3e93305ac4db68d9dc897a5ef105d55f4

i didn't implement history by minutes support as none of the methods i tried seemed to be consistently working. i will keep that feature in mind, but gonna close this issue now, since the players are technically supported now