justchokingaround / lobster

mmm lobster
GNU General Public License v2.0
572 stars 37 forks source link

[bug]: errors when downloading files with special characters #217

Open pokegamer5547 opened 4 months ago

pokegamer5547 commented 4 months ago

Describe the bug So for some shows, like "star vs the forces of evil", when you try to download and use -x flag(happens without debug but just to show error), it says ffmpeg -loglevel error -stats -i https://b-g-eu-9.raffaellocdn.net:2223/v3-hls-playback/6457bc92757cf30f5a9a3784605527fd1e182004b9d2209d0ac054be53f5f9445896d2a220f7a1fb9bbcd8bf2a59a7af07c204be7ef1677ca8f5e9b7ead0943b0a2c42669f2d2364428d63b74591b12460e8dfd84fe52b58215bbaea6a08470f482a7a0999cbf7c3832b14979ed0f1fac67ee0ae2f4008842f3d404debe01afc5ebcad830c787a59138442354712132554e1b8026487e210c87d8873db44d460a88f176b554681d8917df4de1dcdab05/playlist.m3u8 -c copy /sdcard/Movies/Star vs. the Forces of Evil - Season 1 - Eps 1 Star Comes To Earth/Party With A Pony.mp4 "

To Reproduce Steps to reproduce the behavior: Try to download any random episode of "star vs the forces of evil"

Expected behavior It should download

Screenshots Screenshot_20240726-202337_Termux

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Its not filepath issue as i'm able to download other shows. It's only an issue with "star vs the forces of evil". I used debug flag and copied the ffmpeg and it seems having issue due to special characters in the output filename. Maybe removing special characters from filename can be helpful.

lily-bit-0 commented 3 months ago

I just encountered the same issue of slash characters in episode titles messing up the download path, coincidentally also on Star vs. the Forces of Evil. As a temporary workaround you can change the download function to use yt-dlp as described in https://github.com/justchokingaround/lobster/wiki/Configuration#download-video-function. yt-dlp automatically creates missing directories, so it will create directories with parts of the episode name and then download it there instead of failing. But you’ll have to rename and move the downloaded files afterwards, so it’s still a little tedious.

justchokingaround commented 3 months ago

was this fixed in https://github.com/justchokingaround/lobster/commit/942ad9f466a1056fe48961826c1ff34da4beb976 ?

pokegamer5547 commented 3 months ago

Well currently i'm having some issues with lobster running 4.3.0 (termux android) so a different issue came before i could test current one. Screenshot_20240804-065101_Termux It's first time i'm having this one, can we just use TMPDIR variable instead of specifying filepath? It ahould for both linux and unix.

I manged to solve it by editing the lobster script myself and changing paths.

But the star vs is still not able to download with yt-dlp Screenshot_20240804-070429_Termux

But ffmpeg is finally downloading now, just giving different issue unrelated to lobster i think. Screenshot_20240804-070930_Termux

justchokingaround commented 3 months ago

okay, here's a list of TODOs then: