search

justcla / HotTips

Visual Studio extension that provides Tip of the Day
MIT License
3 stars 9 forks source link

Adds modern CommandHandler to enable dynamic tips #31

Closed AmadeusW closed 6 years ago

AmadeusW commented 6 years ago

Reacts to editor commands. This is a base building block to achieve dynamic tips. Note that this uses a nuget package from a myget feed. I'm updating the NuGet.config so that this works on all computers. Please verify prior to merging.

justcla commented 6 years ago

Thanks. I took a look. We should chat more about it. We also have Pramod working on Dynamic tips from India, so we should all get on the same page.

Tell me, will the command listener always be run? Is there an issue with ordering?

From: Amadeusz Wieczorek notifications@github.com Sent: Friday, July 20, 2018 8:48 AM To: justcla/HotTips HotTips@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [justcla/HotTips] Adds modern CommandHandler to enable dynamic tips (#31)

Reacts to editor commands. This is a base building block to achieve dynamic tips. Note that this uses a nuget package from a myget feed. I'm updating the NuGet.config so that this works on all computers. Please verify prior to merging.

You can view, comment on, or merge this pull request online at:

https://github.com/justcla/HotTips/pull/31https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjustcla%2FHotTips%2Fpull%2F31&data=02%7C01%7Cjustcla%40microsoft.com%7Cecb70e6e2efd4cc4c37808d5ee582768%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636676984744218353&sdata=ODeCFS79MqWAROJiDp3AHDh4VHEwECcgOnDU0tHSyus%3D&reserved=0

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjustcla%2FHotTips%2Fpull%2F31&data=02%7C01%7Cjustcla%40microsoft.com%7Cecb70e6e2efd4cc4c37808d5ee582768%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636676984744278408&sdata=WOiW3%2Fwvp8GeoHVQ%2BC9QIGJI968m3xDPxJ%2BlwJ%2Bjix4%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQVnT1npU6NW3Xag_8VJrb06VOvli7BLks5uIfuogaJpZM4VYQFr&data=02%7C01%7Cjustcla%40microsoft.com%7Cecb70e6e2efd4cc4c37808d5ee582768%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636676984744278408&sdata=3NmsIGBAOMD8Hn6OGsn%2F4N%2F9wteHcqXc8L%2BWbqdZlxU%3D&reserved=0.

AmadeusW commented 6 years ago

It will be always running, unless:

  1. Another command handler says that the command is unavailable
  2. There are no other command handlers