Open justcla opened 5 years ago
Update source.extension.manifest. Increase (or remove) the max Core Editor prerequisite.
Change: Version="[15.0,16.0)" To: Version="[15.0,)"
Hey Justin - we're upgrading to vs 2019 on the Microsoft owned extension - https://github.com/Microsoft/VS-ColorThemes And planning to port the marketplace extension to the same publisher as Color Theme Editor so that we can publish to the marketplace as well, since the source repo on GitHub is under the Microsoft account as well. Sound good?
Unfortunately changing version won't help, here is modified version:
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011">
<Metadata>
<Identity Id="VSColorThemes.8643b166-c815-4f07-b9ec-64be1f7b8a59" Version="1.0.9" Language="en-US" Publisher="Open Source Community" />
<DisplayName>Color Themes for Visual Studio</DisplayName>
<Description xml:space="preserve">Provides additional color themes for Visual Studio IDE. Includes themes contributed by community members plus themes from Microsoft's Color Themes Editor.</Description>
<MoreInfo>https://github.com/Microsoft/VS-ColorThemes</MoreInfo>
<License>EULA.rtf</License>
<ReleaseNotes>ReleaseNotes.txt</ReleaseNotes>
<Icon>VsColorTheme_Icon_90x.png</Icon>
</Metadata>
<Installation>
<InstallationTarget Version="[12.0,)" Id="Microsoft.VisualStudio.IntegratedShell" />
</Installation>
<Dependencies>
<Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" Version="[4.5,)" />
</Dependencies>
<Assets>
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\Bigface.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\DarkExtraContrast.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\DarkWithLightEditor.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\Green.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\GreenShah.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\LightWithDarkEditor.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\PlainDark.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\Purple.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\Red.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\SolarizedDark.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\SolarizedLight.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\SublimeMaterialDark.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="Themes\Tan.pkgdef" />
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="ThemeRegistration.pkgdef" />
</Assets>
<Prerequisites>
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0,)" DisplayName="Visual Studio core editor" />
</Prerequisites>
</PackageManifest>
On installation I get an error:
as it seems like Microsoft.VisualStudio.Component.CoreEditor
doesn't exist in 2019. Did anyone succeed in doing this?
I've managed to install this extension to VS2019. It was enough to apply the same change also in catalog.json and manifest.json files.
The Color Themes extension needs to be upgraded so that it runs on VS2019.