Fix for #769: Wildcard bug on second-level domain

justcoding121 / titanium-web-proxy

A cross-platform asynchronous HTTP(S) proxy server in C#.

MIT License

1.92k stars 598 forks source link

Fix for #769: Wildcard bug on second-level domain #920

Closed fahlisaputra closed 1 year ago

fahlisaputra commented 2 years ago

When openning second-level domain like ".ac.id, .co.id, .vn.ua, etc" it will show message "Couldn't authenticate host". Issue #769

Doneness:

[x] Build is okay - I made sure that this change is building successfully.
[x] No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
[x] Branching - If this is not a hotfix, I am making this request against the develop branch

andrewfblake commented 1 year ago

ah amazing, we're getting the same issue here with the wildcard certificate not authenticing - looking forward to this ticket being merged in! thank you!

justcoding121 commented 1 year ago

@honfika Do you agree with this change?

justcoding121 commented 1 year ago

I modified the logic a little bit.

justcoding121 commented 1 year ago

I don’t think there is a perfect solution to this. We can add an proxy flag option to disable wild card Certificates altogether in future.

andrewfblake commented 1 year ago

Good morning, Sensational, thank you! I forked and added the original fix into a local build yesterday to do a little testing and it was working great. Agree with your change too. Yeah, watching the logs, there were still some other resources from the site (like third party adverts, and some google domains etc) that were failing with a 'couldn't authenticate host' but as you say, not sure there is a perfect solution to this and the flag seems like a good feature in the future. Thanks again, really appreciate your help and amazing project.

fahlisaputra commented 1 year ago

Thanks!