justdan96 / tsMuxer

tsMuxer is a transport stream muxer for remuxing/muxing elementary streams, EVO/VOB/MPG, MKV/MKA, MP4/MOV, TS, M2TS to TS to M2TS. Supported video codecs H.264/AVC, H.265/HEVC, VC-1, MPEG2. Supported audio codecs AAC, AC3 / E-AC3(DD+), DTS/ DTS-HD.
Apache License 2.0
830 stars 140 forks source link

heap-buffer-overflow in ./tsMuxer/vvc.cpp:331:55 in VvcVpsUnit::deserialize() #788

Closed gandalf4a closed 9 months ago

gandalf4a commented 9 months ago

Version​

$ git show​
commit 2539d074cd4da0547b97aedd8bc12252b973907c (HEAD -> master, tag: nightly-2023-10-05-01-55-56, origin/master, origin/HEAD)​
Author: jcdr428 <jessiedeer@hotmail.com>​
Date:   Wed Oct 4 10:17:02 2023 +0100​
```​
​
# Platform​
```​
$ uname -a​
Linux user-GE40-2PC-Dragon-Eyes 6.2.0-33-generic #33~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Sep  7 10:33:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux​
```​
​
# Asan​
```​
tsMuxeR version git-2539d07. github.com/justdan96/tsMuxer
=================================================================
==541910==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60200000ea78 at pc 0x560e20a1ad9e bp 0x7ffe91452810 sp 0x7ffe91452808
READ of size 8 at 0x60200000ea78 thread T0
    #0 0x560e20a1ad9d in std::_Bit_reference::operator=(bool) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_bvector.h:93:8
    #1 0x560e20a1ad9d in VvcVpsUnit::deserialize() /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/vvc.cpp:331:55
    #2 0x560e20a37813 in VVCStreamReader::checkStream(unsigned char*, int) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/vvcStreamReader.cpp:60:24
    #3 0x560e207167bf in METADemuxer::detectTrackReader(unsigned char*, int, AbstractStreamReader::ContainerType, int, int) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/metaDemuxer.cpp:791:21
    #4 0x560e20709766 in METADemuxer::DetectStreamReader(BufferedReaderManager const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/metaDemuxer.cpp:685:35
    #5 0x560e2062ea7a in detectStreamReader(char const*, MPLSParser*, bool) /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/main.cpp:114:34
    #6 0x560e20642efb in main /home/user/fuzzing_tsMuxer/tsMuxer/tsMuxer/main.cpp:689:17
    #7 0x7f1c63429d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #8 0x7f1c63429e3f in __libc_start_main csu/../csu/libc-start.c:392:3
    #9 0x560e203c9d24 in _start (/home/user/fuzzing_tsMuxer/tsMuxer/build/tsMuxer/tsmuxer+0x249d24) (BuildId: 93aa533ae68cbad6d874b6199ee386d19d3a575e)

0x60200000ea78 is located 0 bytes to the right of 8-byte region [0x60200000ea70,0x60200000ea78)
allocated by thread T0 here:
    #0 0x560e2048793d in operator new(unsigned long) (/home/user/fuzzing_tsMuxer/tsMuxer/build/tsMuxer/tsmuxer+0x30793d) (BuildId: 93aa533ae68cbad6d874b6199ee386d19d3a575e)
    #1 0x560e20a31410 in __gnu_cxx::new_allocator<unsigned long>::allocate(unsigned long, void const*) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
    #2 0x560e20a31410 in std::allocator_traits<std::allocator<unsigned long> >::allocate(std::allocator<unsigned long>&, unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:464:20
    #3 0x560e20a31410 in std::_Bvector_base<std::allocator<bool> >::_M_allocate(unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_bvector.h:550:16
    #4 0x560e20a31410 in std::vector<bool, std::allocator<bool> >::_M_initialize(unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_bvector.h:1141:31
    #5 0x560e20a31410 in std::vector<bool, std::allocator<bool> >::vector(std::vector<bool, std::allocator<bool> > const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_bvector.h:663:2

SUMMARY: AddressSanitizer: heap-buffer-overflow /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_bvector.h:93:8 in std::_Bit_reference::operator=(bool)
Shadow bytes around the buggy address:
  0x0c047fff9cf0: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x0c047fff9d00: fa fa 00 fa fa fa 00 fa fa fa fd fa fa fa 00 fa
  0x0c047fff9d10: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x0c047fff9d20: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x0c047fff9d30: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
=>0x0c047fff9d40: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00[fa]
  0x0c047fff9d50: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x0c047fff9d60: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x0c047fff9d70: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
  0x0c047fff9d80: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa fd fa
  0x0c047fff9d90: fa fa 00 fa fa fa 00 fa fa fa 00 fa fa fa 00 fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==541910==ABORTING
```​
​
# Reproduce​
```​
./tsmuxer poc​
```​
 ​
# POC File​
​https://github.com/gandalf4a/crash_report/blob/main/tsMuxer/poc_hbo_vvc

# Credit​
```​
Gandalf4a​
jcdr428 commented 9 months ago

Thanks @gandalf4a