justdan96 / tsMuxer

tsMuxer is a transport stream muxer for remuxing/muxing elementary streams, EVO/VOB/MPG, MKV/MKA, MP4/MOV, TS, M2TS to TS to M2TS. Supported video codecs H.264/AVC, H.265/HEVC, VC-1, MPEG2. Supported audio codecs AAC, AC3 / E-AC3(DD+), DTS/ DTS-HD.
Apache License 2.0
830 stars 140 forks source link

Dolby Vision bug #798

Closed Hellboy00000 closed 8 months ago

Hellboy00000 commented 8 months ago

Dolby Vision bug in last version "2023-10-21-01-50-32"

Original movie DV-1-original

Good tsMuxer 2023-09-30-01-50-24 DV-3-2023-09-30-01-50-24

Bad tsMuxer 2023-10-21-01-50-32 DV-2-2023-10-21-01-50-32

I think the bug was introduced here: https://github.com/justdan96/tsMuxer/issues/781

I don't understand the use of "Dolby Vision MKV to BD" because those MKV are cropped and when they are used with tsMuxer the picture looks stretch. So you need to encode an encoded video to add the black bars and that make the video looks worse.

DreckSoft commented 8 months ago

Of course you can only mux them to BD of they uncropped. No you do not need to reencode anything. Yes, you will lose DV but the result plays fine as HDR10.

Of course the patch was not supposed to break anything. The second stream should be recognized as DV_EL but it isn't.

Then I don't know how to patch it so both cases create a correct result.

Hellboy00000 commented 8 months ago

I always thought you need to encode again to add black bars. How you add the black bars without encoding?

DreckSoft commented 8 months ago

Why should I add black bars to a 2160p file? That does not make any sense.

Hellboy00000 commented 8 months ago

I mean for files that are cropped. How you add the black bars without encoding?

Edit: Latest version work correctly.