search

justdan96 / tsMuxer

tsMuxer is a transport stream muxer for remuxing/muxing elementary streams, EVO/VOB/MPG, MKV/MKA, MP4/MOV, TS, M2TS to TS to M2TS. Supported video codecs H.264/AVC, H.265/HEVC, VC-1, MPEG2. Supported audio codecs AAC, AC3 / E-AC3(DD+), DTS/ DTS-HD.
Apache License 2.0
829 stars 140 forks source link

heap buffer over-read is found in MovDemuxer::mov_read_esds #855

Closed iwashiira closed 3 months ago

iwashiira commented 3 months ago

Our fuzzer found heap buffer over-read in movDemuxer in the current master(75c9cb3). PoC is here.

#include "bufferedReaderManager.h"
#include "vod_common.h"
#include "abstractDemuxer.h"
#include "movDemuxer.h"
#include <cstdint>
#include <fs/systemlog.h>

using namespace std;

BufferedReaderManager readManager(2, DEFAULT_FILE_BLOCK_SIZE, DEFAULT_FILE_BLOCK_SIZE + MAX_AV_PACKET_SIZE,
                                  DEFAULT_FILE_BLOCK_SIZE / 2);

int main(int argc, char* argv[]) {
    string fileName = argv[1];
    AbstractDemuxer* demuxer = new MovDemuxer(readManager);

    uint32_t fileBlockSize = demuxer->getFileBlockSize();
    demuxer->openFile(fileName);
    return 0;
}

Following is an output of ASAN. vuln12.mov is in poc12.zip

$ tsmuxer ../crash/vuln12.mov
=================================================================
==76002==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000000a91 at pc 0x55fdc3d9597f bp 0x7fffc19e2ff0 sp 0x7fffc19e2fe0
READ of size 1 at 0x602000000a91 thread T0
    #0 0x55fdc3d9597e in MovDemuxer::mov_read_esds(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41d97e)
    #1 0x55fdc3d8e512 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416512)
    #2 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #3 0x55fdc3d944fd in MovDemuxer::mov_read_stsd(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41c4fd)
    #4 0x55fdc3d8e6ce in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4166ce)
    #5 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #6 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #7 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #8 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #9 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #10 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #11 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #12 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #13 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #14 0x55fdc3d91034 in MovDemuxer::mov_read_trak(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x419034)
    #15 0x55fdc3d8e7ac in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4167ac)
    #16 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #17 0x55fdc3d92bf3 in MovDemuxer::mov_read_moov(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41abf3)
    #18 0x55fdc3d8e63a in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41663a)
    #19 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #20 0x55fdc3d8b635 in MovDemuxer::readHeaders() (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x413635)
    #21 0x55fdc3d8a79a in MovDemuxer::openFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41279a)
    #22 0x55fdc3cdae45 in main (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x362e45)
    #23 0x7fd5f095ad8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #24 0x7fd5f095ae3f in __libc_start_main_impl ../csu/libc-start.c:392
    #25 0x55fdc3bf00d4 in _start (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x2780d4)

0x602000000a91 is located 0 bytes to the right of 1-byte region [0x602000000a90,0x602000000a91)
allocated by thread T0 here:
    #0 0x7fd5f1064357 in operator new[](unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:102
    #1 0x55fdc3d956cb in MovDemuxer::mov_read_esds(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41d6cb)
    #2 0x55fdc3d8e512 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416512)
    #3 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #4 0x55fdc3d944fd in MovDemuxer::mov_read_stsd(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41c4fd)
    #5 0x55fdc3d8e6ce in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4166ce)
    #6 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #7 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #8 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #9 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #10 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #11 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #12 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #13 0x55fdc3d8e4a3 in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4164a3)
    #14 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #15 0x55fdc3d91034 in MovDemuxer::mov_read_trak(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x419034)
    #16 0x55fdc3d8e7ac in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x4167ac)
    #17 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #18 0x55fdc3d92bf3 in MovDemuxer::mov_read_moov(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41abf3)
    #19 0x55fdc3d8e63a in MovDemuxer::ParseTableEntry(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41663a)
    #20 0x55fdc3d8eefb in MovDemuxer::mov_read_default(MovDemuxer::MOVAtom) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x416efb)
    #21 0x55fdc3d8b635 in MovDemuxer::readHeaders() (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x413635)
    #22 0x55fdc3d8a79a in MovDemuxer::openFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41279a)
    #23 0x55fdc3cdae45 in main (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x362e45)
    #24 0x7fd5f095ad8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

SUMMARY: AddressSanitizer: heap-buffer-overflow (/home/vagrant/tsmuxer/for_build/build/tsMuxer/tsmuxer+0x41d97e) in MovDemuxer::mov_read_esds(MovDemuxer::MOVAtom)
Shadow bytes around the buggy address:
  0x0c047fff8100: fa fa fd fa fa fa fd fa fa fa fd fa fa fa fd fa
  0x0c047fff8110: fa fa fd fd fa fa fd fa fa fa fd fa fa fa fd fa
  0x0c047fff8120: fa fa fd fa fa fa fd fd fa fa 01 fa fa fa 00 00
  0x0c047fff8130: fa fa fd fa fa fa fd fa fa fa fd fd fa fa fd fa
  0x0c047fff8140: fa fa fd fa fa fa fd fd fa fa fd fa fa fa fd fd
=>0x0c047fff8150: fa fa[01]fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8160: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8170: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8180: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8190: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff81a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==76002==ABORTING

It is caused by following code. https://github.com/justdan96/tsMuxer/blob/5f43ab2a45482ad448524dc61a1ab7204ca8849d/tsMuxer/movDemuxer.cpp#L1637-L1647

While there is code to access a fixed index, such as codec_priv[1], there is no comparison between this index and codec_priv_size. If codec_priv_size = 1, then over-read occurs.

Ricerca Security, Inc.