search

justdice / react-native-advertising-id

React Native bridge for fetching advertising info on iOS and Android
MIT License
37 stars 31 forks source link

Bump android build versions for newer react native #12

Open slaci opened 4 years ago

slaci commented 4 years ago

Hello!

When building a react-native 0.61.5 project with this lib included by ./gradlew assembleRelease the build fails because this lib has too old android targets:

1 exception was raised by workers: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed error: resource android:style/TextAppearance.Material.Widget.Button.Borderless.Colored not found. error: resource android:style/TextAppearance.Material.Widget.Button.Colored not found.

In this PR I matched the targets with the current targets of the 0.61.5 version.

The yarn android --variant=release command works without this somehow, but the above mentioned assembleRelease gradle command does not!

The buildToolsVersion is not neccessary for react native libs I think, but if im wrong then it should be set to 28.0.3.

ptelad commented 4 years ago

+1

ShubhamBathe-KM commented 3 years ago

+1