justdice / react-native-advertising-id

React Native bridge for fetching advertising info on iOS and Android
MIT License
37 stars 31 forks source link

Doesn't work with RN 0.61+ #4

Open ivanszhuravlev opened 4 years ago

ivanszhuravlev commented 4 years ago

The podspec needs to be moved out of ios folder, and maybe some more changes need to be done

FlorianBergmann commented 4 years ago

Please try again with version 1.0.10

ghost commented 4 years ago

@FlorianBergmann I'm using 1.0.10 with RN 0.61.5 and I get error "cannot read property 'getAdvertisingId' of undefined"

ShVitaliy commented 4 years ago

i have the same issue with RN 0.61.5 and 1.0.10 version. Also you have an error in readme. getPackages methods locate in MainApplication.java (not in MainActivity)

FlorianBergmann commented 4 years ago

It should now work with RN 0.61 with version 1.0.11

vikasverma92 commented 4 years ago

@FlorianBergmann I'm using 1.0.10 with RN 0.61.5 and I get error "cannot read property 'getAdvertisingId' of undefined"

With RN 0.61.x, we still have to add

    <application>
        <meta-data
            android:name="com.google.android.gms.ads.AD_MANAGER_APP"
            android:value="true"/>
    </application>

in AndroidManifest.xml.

vikasverma92 commented 4 years ago

@FlorianBergmann I'm using 1.0.10 with RN 0.61.5 and I get error "cannot read property 'getAdvertisingId' of undefined"

With RN 0.61.x, we still have to add

    <application>
        <meta-data
            android:name="com.google.android.gms.ads.AD_MANAGER_APP"
            android:value="true"/>
    </application>

in AndroidManifest.xml.

Release App is still crashing after this.