search

justdomains / ci

Automated scripts to support converting filter lists (in various formats) to "domain-only" lists for use in DNS / domain-blocking tools like Pi-Hole. Used to create: justdomains/blocklists
https://github.com/justdomains/blocklists
MIT License
21 stars 6 forks source link

Domains for third-party requests #1

Open dimqua opened 5 years ago

dimqua commented 5 years ago

Hi there, I noticed that your blocklists contain domains from rules like this: ||example.com^$third-party. Why block them?

swiftlyfalling commented 5 years ago

@dimqua: The configuration specific to that is currently here: https://github.com/justdomains/ci/blob/7d0d1533f625c9a5740da1d923205a87db1b0964/convertlists.py#L556

Did you encounter a situation in which including these entries is problematic?

I suppose it would be possible to provide separate versions of the converted lists with them included and excluded.

argonym commented 3 years ago

Hi @swiftlyfalling, the EasyLists are primarily meant for blocking inside browsers. In contrast, your justdomains are primarily used for DNS-based blocking. At least that's how we are using them. So in case of DNS-based blocking it's obviously impossible to distinguish 2nd from 3rd party sites, and some over-blocking of domains flagged with the third-party option is to be expected.

Here are two particular peculiar cases:

download.microsoft.com         CNAME  20    Answer     2-01-4ca6-0004.cdx.cedexis.net

download.windowsupdate.com     CNAME  18    Answer     wu-fg-shim.trafficmanager.net
wu-fg-shim.trafficmanager.net  CNAME  18    Answer     2-01-3cf7-0009.cdx.cedexis.net

cedexis.net ist contained in easyprivacy with third-party. Seems to be a large DNS+CDN(+Tracking) provider.

Use cases vary. I think your approach of two versions of each list makes a lot of sense, and I'd appreciate if you made it happen. :)

argonym commented 3 years ago

@dimqua, why did you close this issue? Am I missing something?

dimqua commented 3 years ago

@argonym I thought that the project is no longer maintained, but I was wrong. Only this repository isn't maintained.

argonym commented 3 years ago

@dimqua: Please re-open this issue, as it still exists (regardless of the state of the project). Maybe @swiftlyfalling is inclined to implement the change/feature. Or somebody else stumbling over it might make a PR.