search

justeat / JustLog

JustLog brings logging on iOS to the next level. It supports console, file and remote Logstash logging via TCP socket with no effort. Support for logz.io available.
https://tech.justeattakeaway.com/
Apache License 2.0
519 stars 90 forks source link

[Crash] Over committing from RepeatingTimer #114

Closed freak4pc closed 9 months ago

freak4pc commented 3 years ago

Hey there, We noticed there's a somewhat repeating crash on JustLog that looks like this:

Crashed: com.apple.root.default-qos.overcommit
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000
image

Over-comitting basically means the queue can't handle the amount of scheduled pieces of work simultaneously with the provided quality of service. I believe this is related to the fact you're using makeTimerSource and using the default queue instead of possibly creating your own queue with a different quality of service, but haven't had a chance to properly investigate.

Are you aware of this crash? Couldn't find any other reports on it. Thanks!

albertodebortoli commented 9 months ago

Hi @freak4pc, I'm sorry the team didn't address this. I don't think we have encountered this specific crash in our apps. I'm gonna go ahead and close this as we are deprecating the component and archiving the repo.