Improve log message serialisation fallback. Log the failure

justeat / JustLog

JustLog brings logging on iOS to the next level. It supports console, file and remote Logstash logging via TCP socket with no effort. Support for logz.io available.

https://tech.justeattakeaway.com/

Apache License 2.0

519 stars 90 forks source link

Improve log message serialisation fallback. Log the failure #93

Closed Henbyr closed 3 years ago

Henbyr commented 3 years ago

Added JSON validation when Logger is trying converting NSError to readable object. If validation is failed we write description of the object which is failed. It will provide additional information about non-serialisable objects inside userInfo.

Henbyr commented 3 years ago

Small typo. Also, are there already tests for handling these non-serialisable error cases?

@antoniostrijdom No. There are no tests for these cases for now. I'm planning to analyse the 'problems' logs later and return back with tests. I need to see a whole picture of the problem.

Henbyr commented 3 years ago

Unit tests will be added to the PR with next commit