search

justeat / Topshelf.Nancy

Nancy endpoint for the Topshelf service host providing additional support around URL reservations. — Edit
Other
65 stars 30 forks source link

Nancy boostrapping occurs during install and uninstall #12

Closed jbuedel closed 8 years ago

jbuedel commented 8 years ago

I noticed that my subclass of DefaultNancyBoostrapper is being executed anytime NancyServiceConfiguratorExtensions.WithNancyEndpoint is called. So basically, every time my TopShelf hosting app is run, including during installs and uninstalls. In fact, it runs before my InstallHostConfiguratorExtensions.BeforeInstall() lambda is even called.

I expected the Nancy bootstrapping to run around the same time as when Topshelf's WhenStarted() was called. This seems like a bug to me. Do you agree, or have any suggestions on how I might do things differently?

jbuedel commented 8 years ago

I've created a pull request for this.

https://github.com/justeat/Topshelf.Nancy/pull/13

AnthonySteele commented 8 years ago

The PR has been merged. Can we close this issue?