justeat / ZendeskApiClient

C# Client for working with the Zendesk API
Other
64 stars 85 forks source link

[RED-1965] - Add support to a new resource - /api/v2/tags #316

Closed fbvilela closed 10 months ago

fbvilela commented 11 months ago

Description

adds support to Tags -> /api/v2/tags

The idea is that this PR will be used as a guide for future implementations of endpoints that support cursor pagination.

fbvilela commented 11 months ago

@mikerogers123 hello again, would appreciate your feedback. this PR depends on https://github.com/justeat/ZendeskApiClient/pull/312

so just take a look at the last commit 🙏

mikerogers123 commented 11 months ago

@fbvilela hello! Just finished releasing the CBP changes. Probably easier for me to review this PR once latest is merged in :)

fbvilela commented 11 months ago

thanks @mikerogers123 , I have updated the branch. it's all good to review 👍 thanks in advance

fbvilela commented 11 months ago

@mikerogers123 gentle bump on this again :)

I have an exciting Pull Request coming right after this!

but first it would be good to merge/ get any feedback in this branch! Thanks in advance! 🙏

mikerogers123 commented 10 months ago

@fbvilela looks good to me. Can you bump version? Will need to be to 7.0.4 because there is a competing PR going in at the moment. Then I can approve, merge and release

fbvilela commented 10 months ago

All good on this one, @mikerogers123 ?