search

justeat / ZendeskApiClient

C# Client for working with the Zendesk API
Other
65 stars 86 forks source link

develop -> master (#319 #316) #320

Closed mikerogers123 closed 11 months ago

mikerogers123 commented 1 year ago

https://github.com/justeat/ZendeskApiClient/pull/319 https://github.com/justeat/ZendeskApiClient/pull/316

mikerogers123 commented 1 year ago

@fbvilela looks like the integration tests for the TagsResource is failing, are you able to take a look? Might be related to the fact that these tests are running against a different Zendesk instance than yours. The tests should be portable, and instnace-agnostic

========================================
Run-Integration-Tests
========================================
  Determining projects to restore...
  All projects are up-to-date for restore.
  ZendeskApi.Client -> D:\a\ZendeskApiClient\ZendeskApiClient\src\ZendeskApi.Client\bin\Release\net6.0\ZendeskApi.Client.dll
  ZendeskApi.Client.IntegrationTests -> D:\a\ZendeskApiClient\ZendeskApiClient\test\ZendeskApi.Client.IntegrationTests\bin\Release\net6.0\ZendeskApi.Client.IntegrationTests.dll
Test run for D:\a\ZendeskApiClient\ZendeskApiClient\test\ZendeskApi.Client.IntegrationTests\bin\Release\net6.0\ZendeskApi.Client.IntegrationTests.dll (.NETCoreApp,Version=v6.0)
Microsoft (R) Test Execution Command Line Tool Version 17.3.3 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:01.33]     ZendeskApi.Client.IntegrationTests.Resources.TagsResourceTest.GetAllAsync_WhenCalledWithCursorPagination_ShouldBePaginatable [FAIL]
  Failed ZendeskApi.Client.IntegrationTests.Resources.TagsResourceTest.GetAllAsync_WhenCalledWithCursorPagination_ShouldBePaginatable [747 ms]
  Error Message:
   Assert.Equal() Failure: Values differ
Expected: 5
Actual:   0
  Stack Trace:
     at ZendeskApi.Client.IntegrationTests.Resources.TagsResourceTest.GetAllAsync_WhenCalledWithCursorPagination_ShouldBePaginatable() in D:\a\ZendeskApiClient\ZendeskApiClient\test\ZendeskApi.Client.IntegrationTests\Resources\TagsResourceTests.cs:line 30
--- End of stack trace from previous location ---

Failed!  - Failed:     1, Passed:    78, Skipped:     0, Total:    79, Duration: 41 s - ZendeskApi.Client.IntegrationTests.dll (net6.0)
An error occurred when executing task 'Run-Integration-Tests'.
Error: One or more errors occurred.
.NET Core CLI: Process returned an error (exit code 1).
Error: Process completed with exit code 1.
fbvilela commented 1 year ago

Hi @mikerogers123 , sorry for the late reply... this is just because the account you are using doesn't have enough ticket tags. I will modify my test to create tickets, execute the test, delete the tickets. leave it with me. a new PR will be coming up soon