justeattakeaway / pie

Globally shared packages for PIE
Apache License 2.0
27 stars 8 forks source link

feat(pie-toast-provider): DSW-2222 toast provider basic functionality #2098

Open raoufswe opened 5 days ago

raoufswe commented 5 days ago

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR πŸ”—
NextJS 14 deployment πŸ”—
Nuxt 3 deployment πŸ”—
Vanilla deployment πŸ”—

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

Reviewer 2

changeset-bot[bot] commented 5 days ago

πŸ¦‹ Changeset detected

Latest commit: 7b0a454bfe5a0440b8d2b64ea53341f1708c6ca0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

raoufswe commented 3 days ago

/snapit

pie-design-system-bot commented 3 days ago

Starting a new snapshot build. You can view the logs here.

pie-design-system-bot commented 3 days ago

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

[!NOTE] If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-toast@0.0.0-snapshot-release-20241129151616 --mode=update-lockfile
yarn up @justeattakeaway/pie-toast-provider@0.0.0-snapshot-release-20241129151616 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20241129151616 --mode=update-lockfile

Then finally:

yarn install
raoufswe commented 3 days ago

/snapit

pie-design-system-bot commented 3 days ago

Starting a new snapshot build. You can view the logs here.

pie-design-system-bot commented 3 days ago

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

[!NOTE] If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-toast@0.0.0-snapshot-release-20241129161131 --mode=update-lockfile
yarn up @justeattakeaway/pie-toast-provider@0.0.0-snapshot-release-20241129161131 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20241129161131 --mode=update-lockfile

Then finally:

yarn install
pie-design-system-bot commented 3 days ago
Fails
:no_entry_sign: You have unchecked checklist items outside the "Not-applicable Checklist items" section. Please ensure all unchecked checkboxes are moved to the appropriate section.
:no_entry_sign: You have unchecked checklist items in Reviewer 1's section. Please ensure all items are addressed before approval.
:no_entry_sign: You have unchecked checklist items in Reviewer 2's section. Please ensure all items are addressed before approval.

Generated by :no_entry_sign: dangerJS against 7b0a454bfe5a0440b8d2b64ea53341f1708c6ca0