As the title suggest, during episode download, when user do Ctrl+C, the progress won't stop or at least prompt UNLESS the episode was successfully downloaded but an exception message: Exiting from the downloading context was thrown after. I think this behavior must be fixed for some use case where user has limited data plan (if user use tethered connection) or wish not to continue downloading the anime.
Reproducing
Try to download an anime from any provider and optimally use range of episodes. In this example, we used allanime with following query:
animdl download -r "27-72" "Xiao Lu He Xiao Lan"
Select which anime that matches, we use option 2 (Xiao Lu He Xiao Lan)
When animdl starts downloading the episode, start pressing/spamming Ctrl+C keystroke.
Observe.
Expected behavior
Either:
A prompt message to cancel shown
Write a log that the episode download was cancelled, and abruptly stop the progress
Observed behavior
Episode kept being downloaded. Once reached 100%, an exception was thrown.
Notes
If user opted in --idm flag, a confirmation shown to stop the episode scraping.
As the title suggest, during episode download, when user do Ctrl+C, the progress won't stop or at least prompt UNLESS the episode was successfully downloaded but an exception message:
Exiting from the downloading contextwas thrown after. I think this behavior must be fixed for some use case where user has limited data plan (if user use tethered connection) or wish not to continue downloading the anime.Reproducing
2(Xiao Lu He Xiao Lan)animdlstarts downloading the episode, start pressing/spamming Ctrl+C keystroke.Expected behavior
Either:
Observed behavior
Episode kept being downloaded. Once reached 100%, an exception was thrown.
Notes
If user opted in
--idmflag, a confirmation shown to stop the episode scraping.Environment
animdlversion:v1.7.24pipxversion:v1.1.0v3.11.2v1.17.11461.0v7.3.6