search

justicel / puppet-couchbase

Puppet couchbase module for auto-scaling of couchbase with puppet
9 stars 30 forks source link

9 total changes #13

Closed AutomationD closed 9 years ago

AutomationD commented 9 years ago
justicel commented 9 years ago

Wow, lots of changes. It'll take me a couple days to have a chance to look at this just as an FYI

justicel commented 9 years ago

I think that I'll be able to accept this as is. Truly appreciate the pull. I'll make sure to note your contribution in the next changelog :). There are a few things I'll need to edit but looks good!

AutomationD commented 9 years ago

Thank you!

One thing I was hoping to discuss - underscores vs hypens. In newer puppet parser classes can't have hyphens at all. But I'mm still confused about file names (cluster init scripts, etc). I'd suggest to bring them all to one form. One thing, for windows, there is no windows package installation yet for moxi resource (so you have to install it in beforehand). I was planning to add it later, after the proof of concept. Also, I have to push moxi package to chocolatey, which means some sort of dependency on chocolatey https://forge.puppetlabs.com/rismoney/chocolatey module, any thoughts?

The other thing, I'd suggest to add some edits to README.md. I could do it too, after you settle down with final version.

Thanks again.

On Tue, Nov 4, 2014 at 8:58 AM, Justice London notifications@github.com wrote:

I think that I'll be able to accept this as is. Truly appreciate the pull. I'll make sure to note your contribution in the next changelog :). There are a few things I'll need to edit but looks good!

— Reply to this email directly or view it on GitHub https://github.com/justicel/puppet-couchbase/pull/13#issuecomment-61673906 .

justicel commented 9 years ago

I hadn't heard about the hyphens thing actually. Good to know! I'll take a look through this codebase and my others to verify I'm not using them anywhere.

AutomationD commented 9 years ago

Yeah, here's the JIRA item: https://tickets.puppetlabs.com/browse/PUP-1576

Sincerely, Dmitry Kireev cel.: +1 (818) 850-5577 email, gtalk: dmitry@kireev.co dmitry@kireev.co skype: kireev.co aim: 336719228

On Tue, Nov 4, 2014 at 1:47 PM, Justice London notifications@github.com wrote:

I hadn't heard about the hyphens thing actually. Good to know! I'll take a look through this codebase and my others to verify I'm not using them anywhere.

— Reply to this email directly or view it on GitHub https://github.com/justicel/puppet-couchbase/pull/13#issuecomment-61720623 .

AutomationD commented 9 years ago

Appreciate the merge.