Code of Ray generation in plucker_embedder

[TingtingLiao]

hi, thanks for your great work!

I have a question about the ray generation here . Since fxfycxcy=[0.5/tan_half_fov, 0.5/tan_half_fov, 0.5, 0.5], the code should be like this?

x = (x+0.5) / w
y = (y+0.5) / h
x = (x - fxfycxcy[:, 2:3]) / fxfycxcy[:, 0:1]
y = (y - fxfycxcy[:, 3:4]) / fxfycxcy[:, 1:2]

instead of

x = x / w
y = w / h
x = (x + 0.5 - fxfycxcy[:, 2:3]) / fxfycxcy[:, 0:1]
y = (y + 0.5 - fxfycxcy[:, 3:4]) / fxfycxcy[:, 1:2]

[kevinchiu19]

I have the same question.