search

justin-chu / react-fast-marquee

A lightweight React component that harnesses the power of CSS animations to create silky smooth marquees.
https://react-fast-marquee.com
MIT License
1.16k stars 95 forks source link

Consider using a string instead of an array for gradientColor #67

Closed kcpru closed 11 months ago

kcpru commented 1 year ago

I noticed that the gradientColor prop in the React component is currently defined as an array [number, number, number]. However, I believe it might be more convenient and flexible to use a string instead. This would allow users to input colors in hex or RGB format.

For example, many popular libraries, like chakra-ui, provide functions such as useColorModeValue for dynamically changing colors. These functions typically return colors as strings, and it would be more convenient to use a similar string representation for the gradientColor prop. This would align with common practices and make it easier for developers to work with the component.

justin-chu commented 11 months ago

Thanks for the suggestion, added this in v1.6.1!