search

justin-eckenweber / OreEarn

OreEarn Plugin für PocketMine-MP
GNU General Public License v3.0
1 stars 2 forks source link

Dependencies #3

Closed JaxkDev closed 5 years ago

JaxkDev commented 5 years ago

Nice plugin first off.

But one small thing is dependencies, they aren't specified on poggit or plugin.yml only readme I would suggest adding it to both poggit and plugin.yml and running a check onEnable to stop errors occuring here $this->getServer()->getPluginManager()->getPlugin("EconomyAPI") that would return null if it doesn't exist, maybe disable plugin if null.

justin-eckenweber commented 5 years ago

Oh, you're right. I'm adding it to the next version! Thank you :)

JaxkDev commented 5 years ago

No problem, good plugin 👍

justin-eckenweber commented 5 years ago

Added in OreEarn Update 1.8.1 thank you!