search

justin-lau / ui-iconpicker

A Bootstrap 3 Icon Picker implemented in AngularJS
http://justin-lau.github.io/ui-iconpicker/
MIT License
32 stars 33 forks source link

UPDATE UI-IC0NPICKER TO WORK WITH ANGULAR 1.3.15 AND BOOTSTRAP 0.13.0 #8

Open sanyam-j opened 9 years ago

justin-lau commented 9 years ago

Thanks for the PR! I have been too occupied on works to update this repo.

I have pulled the code down and have found some problems, I'd be grateful if you could fix them in your repo before I merge the code:

  1. The change of the template should happen in src/scripts/templates/iconpicker.coffee.
  2. The carets on the buttons now face up instead of face down.
  3. The popover now opens on the top of the button instead of below the button.
sanyam-j commented 9 years ago

@justin-lau Fixed all the issues. Thanks.

bhalt commented 8 years ago

can this be accepted @justin-lau ? Running into the same issue.

justin-lau commented 8 years ago

@sanyam-j Sorry for the silence. I have never had the time to review this PR again. One way to quickly use this update on your project would be to use sanyam-j/ui-iconpicker directly from bower or npm. Hope that helps.