search

justin-lovell / hapi-api-secret-key

Protect your API tagged routes with a simple set of known keys. Useful for locking down useage from API managers
13 stars 2 forks source link

HAPI v17 migration #3

Open HEYGUL opened 6 years ago

HEYGUL commented 6 years ago

Migrate the plugin to work with HAPI v17

Related to #2

HEYGUL commented 6 years ago

I just saw TravisCI is running tests against node 4 and 6 versions beside newer ones. I did not keep compatibility with those old versions, if it is a major issue for you, I might take time to keep compatibility.

justin-lovell commented 6 years ago

Hi there! Thank you for submitting the PR; I'm pretty excited about and looked at it, and it appears comprehensive.

For the failing build, let me do some homework to separate out the HAPI pre-17, and as soon as I'm complete, we will release your PR. (I will look at this in 10 hours)

Once again, thank you.

antony commented 6 years ago

HapiJS v17 requires node v8 so there is no point testing against anything < 8.

I think it would be fair to just add a readme item to say that for Hapi < 17, use the 1.x.x series of this plugin, and for v17 and newer, use the 2.x.x series.

Excited to see this merged so I can upgrade to v17!