search

justin-roche / serenade-mode

Emacs minor mode providing integration with Serenade
18 stars 3 forks source link

Fails to ensure needed packages are available and requires unnecessary packages #1

Open rswgnu opened 3 years ago

rswgnu commented 3 years ago

You should try to test your mode with vanilla Emacs, e.g. 'emacs -Q'. Then you'll see packages you expect that are not included and you can either code to make them optional or require their download as part of the installation instructions/process.

For me, yasnippet was required but I don't use it, so package loading failed. After I installed that, I then got (void-variable evil-mode). Surely evil-mode is not necessary to build an interface between Emacs and a voice control engine. If you clean this up, a broader set of Emacs users will be able to utilize your code. Thank you.

justin-roche commented 3 years ago

Thanks for the feedback! I believe this is fixed now. By default helm, yasnippet, and evil should no longer be required. If confirmed, I'll close the issue.