search

justin13601 / ACES

ACES: Automatic Cohort Extraction System for Event-Streams
https://eventstreamaces.readthedocs.io/en/latest/
MIT License
25 stars 1 forks source link

Is it intended to not include the predicate used for `label` in the `target` window to the `referenced_predicates`? #140

Closed Jwoo5 closed 1 month ago

Jwoo5 commented 1 month ago

When TaskExtractorConfig is initialized, referenced_predicates includes 1) the trigger predicate and 2) predicates that are defined in has constraints in each window, but not the label predicate in the target window. This is problematic when the predicate used for label is not in has predicates. Is it intended or an unintended bug that should be fixed?

https://github.com/justin13601/ACES/blob/89291a01522d2c23e45aa0ee6a09c32645f4d1b4/src/aces/config.py#L1292

I saw that all the predicates used in the windows including the trigger predicate are included in the final_predicates, but it is soon dropped by this list comprehension with the constraint if k in referenced_predicates.

Jwoo5 commented 1 month ago

I updated the package to the latest version (0.5.1), and confirmed it is completely resolved there.