search

justinabrahms / imhotep

A static-analysis bot for Github
MIT License
223 stars 42 forks source link

Support custom base branch name #112

Open tslmy opened 1 year ago

tslmy commented 1 year ago

Currently, Imhotep assumes the base branch is called master.

https://github.com/justinabrahms/imhotep/blob/046ec49f7d337fcbcd81dd30b883a3c4bcf6ecc0/imhotep/repomanagers.py#L107

This name is getting deprecated.

We should at least make this a CLI argument.

justinabrahms commented 1 year ago

Agreed. Happy to accept the change. :)

On Sun, Nov 13, 2022, at 9:56 PM, Ming wrote:

Currently, Imhotep assumes the base branch is called master.

https://github.com/justinabrahms/imhotep/blob/046ec49f7d337fcbcd81dd30b883a3c4bcf6ecc0/imhotep/repomanagers.py#L107

This name is getting deprecated.

We should at least make this a CLI argument.

— Reply to this email directly, view it on GitHub https://github.com/justinabrahms/imhotep/issues/112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA6DIWR5HUQJYMXC6XBZLWIHIA5ANCNFSM6AAAAAAR7OHVLA. You are receiving this because you are subscribed to this thread.Message ID: @.***>