Issue #14: Skeleton Pages

dominictdavies commented 5 months ago

Ensure PRs are merged through the squash and merge strategy

This PR involves the creation of (most of) the pages that our website will feature, done through very bare html and bootstrap.

The following pages have been created (final names still subject to change in this PR):

Account creation
Admin
Games
Introduction
Lobby making
Lobby searching
Lobby view

Testing:

[x] No issues and/or errors in browser console
[x] All pages pass the W3C Markup Validation
[x] All pages feature very similar heads
[x] Specific elements across files should be identical, rather than being implemented slightly differently

dominictdavies commented 5 months ago

Should we move the JS and CSS files into separate folders, so that we just have html files in the pages folder?

justinarat commented 5 months ago

Yeah I think we should, could have an overall "skeleton-pages" folder with "html", "css", "javascript" subfolders?

dominictdavies commented 5 months ago

Yeah I think we should, could have an overall "skeleton-pages" folder with "html", "css", "javascript" subfolders?

Ye that sounds good, I think we could still leave the overall folder just called "pages" tho?

justinarat commented 5 months ago

Ye that sounds good, I think we could still leave the overall folder just called "pages" tho?

Yeah sounds good

dominictdavies commented 5 months ago

Also if you guys can think of any changes to page names / if any more pages should be created, now should be the time for us to quickly do so.

justinarat commented 5 months ago

Also if you guys can think of any changes to page names / if any more pages should be created, now should be the time for us to quickly do so.

I was thinking we might need an account page if we add features that lets users edit their account details like their password or email. Might be able to create it later as well with jinja templates.

justinarat commented 5 months ago

Also the head and navbar/header elements are pretty much identical across across all pages, some just have extra stylesheets in the head.

JohnGiampaolo commented 5 months ago

Should we move the "pages" folder to be a subfolder of "app"? In the tutorials, the AgileWebDevDemo has a templates folder within app containing all the HTML pages. Not sure if this is standard practice or personal choice.

JohnGiampaolo commented 5 months ago

I was thinking we might need an account page if we add features that lets users edit their account details like their password or email. Might be able to create it later as well with jinja templates.

Yes definitely, I agree. I think down the line we could even implement account personalization if we have time (pfp changes etc.)

JohnGiampaolo commented 5 months ago

Also if you guys can think of any changes to page names / if any more pages should be created, now should be the time for us to quickly do so.

~~I just had a thought about the Admin page.~~ Piggybacking off of what @justinarat mentioned about an account page, within that page (or even in a separate page), there could be a "My Lobbies" section. ~~Or maybe we could turn Admin into this section.~~ Having a list of multiple lobbies that a user owns would be good as it would allow for easier access to them. By doing so, the user can then access the admin settings or features for each lobby without having to

search for the lobby
remember that they created the lobby

The same goes for lobby members.

This is under the assumption that we are allowing users to create multiple lobbies. If this is an extension feature, we can implement this later on.

justinarat / Teamify

Issue #14: Skeleton Pages #30