justinbarclay / parinfer-rust-mode

Simplifying how you write Lisp
https://shaunlebron.github.io/parinfer/
GNU General Public License v3.0
227 stars 16 forks source link

Update options handling #76

Closed justinbarclay closed 4 months ago

justinbarclay commented 5 months ago

Update options handling to coincide with changes made in parinfer-rust v0.4.5`

TODO:

gagbo commented 5 months ago

I think the parinfer-rust-major-mode-options should also contain the comment char, just because Janet uses #. The other solution would be to add a bunch of hooks to query the major mode for the comment character, but that feels annoying

justinbarclay commented 5 months ago

I think the parinfer-rust-major-mode-options should also contain the comment char, just because Janet uses #. The other solution would be to add a bunch of hooks to query the major mode for the comment character, but that feels annoying

Ahh, cool! I know nothing of what makes good defaults for any of the other modes. I kind of just stole the defaults from the CLI version as a starting point.

justinbarclay commented 5 months ago

@gagbo would you be willing to test out this branch and see if anything breaks for you? I'll be testing it myself, but I only run parinfer while working in Emacs these days, so I don't have as much opportunity to vet this thoroughly

gagbo commented 5 months ago

I'll test it in a few days, I'll try to get a few people in the Doom Emacs discord to test as well

justinbarclay commented 4 months ago

@gagbo I'm not sure if you've had much time to play with this, but I am probably going to merge the work sometime this weekend.