search

justinbleach / saml-client

A dead simple SAML 2.0 client.
MIT License
164 stars 96 forks source link

Redirect binding requires compression #25

Open yyy opened 5 years ago

yyy commented 5 years ago

In Redirect binding, SAML Request should be compressed and then base64-encoded. But the current (1.5.0) code doesn't compress. That makes some IDPs (OpenAM) unhappy.

krystianity commented 3 years ago

@yyy did you figure out a way to make this client work with OpenAM?

yyy commented 3 years ago

@yyy did you figure out a way to make this client work with OpenAM?

@krystianity Yes. See my workaround at https://github.com/coveooss/saml-client/issues/26#issuecomment-549585859

krystianity commented 3 years ago

Thanks @yyy - just to be clear, you are running this code on your SP side before redirecting to the OpenAM IdP right? There is now way in OpenAM to handle this? And are you experiencing any other issues when accepting SAML Responses from OpenAM with this client, in terms of compression?

yyy commented 3 years ago

Correct. I'm modifying the SAML Request before sending it to OpenAM. I haven't investigated whether this can be fixed on OpenAM site, but I doubt it.

I haven't had any problems consuming the SAML response.

On Feb 17, 2021, at 2:07 PM, Christian Fröhlingsdorf <notifications@github.com mailto:notifications@github.com> wrote:

Thanks @yyy https://github.com/yyy - just to be clear, you are running this code on your SP side before redirecting to the OpenAM IdP right? There is now way in OpenAM to handle this? And are you experiencing any other issues when accepting SAML Responses from OpenAM with this client, in terms of compression?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coveooss/saml-client/issues/25#issuecomment-780886286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDVRAY2IAXJXUFWGMNO53S7Q42TANCNFSM4GXSLGMA.