search

justincely / lightcurve

Turn time-tag spectral data into lightcurves
http://hstlightcurve.readthedocs.io
Other
10 stars 7 forks source link

Handling of recent TDS files #37

Open jcv109 opened 3 years ago

jcv109 commented 3 years ago

Dear Justin, It seems that recent tds files have a different structure than older ones. Meanwhile the old tds files specified only one record per optical element, aperture and segment, new tds files contain several records per optical element and segment, being valid for any aperture, different records being only different by the centralwavelenght. This produces that the tds correction may not applied, because the condition in routine 'get_tds' trying to match the aperture of the file to correct with the aperture in the tds file is not fulfilled (there is no label 'PSA' or 'BOA' in tds file any longer, but the label 'ANY' instead). Moreover, several records could be found in case this condition is skipped. If a fix or hint or workaround could be provided, that should be very appreciated. Thanks in advance.

sean-lockwood commented 3 years ago

PR #38 should address this issue.

justincely commented 3 years ago

Also need to add in backwards compat before release. @sean-lockwood recommended triggering off if 'CENWAVE' in tds_data.columns.names: