Closed phylib closed 3 years ago
Hey @phylib, thank you for asking!
I do agree with you on the more documentation part. For now, major of the code is separated enough to be at understandable with the current documentation. I am not a big fan of Docstring (I have worked on many projects with it) and since I will be the major one working on this project (with security portion), I find it easier to not incorporate the Docstring way of documenting, at least not yet.
However, I took out the source code comments (for the purposes of merging) to keep the same documenting style throughout this github repo. I have noted the comments you provided though.
Feel free to add your comments back in your fork to make it clearer.
I have a couple of comments to your reply:
Hi @justincpresley, in your test case, you had some StateVector generation before actually parsing the TLV. I did not see a reason for that. I removed that and added a test case to check if generated TLVs also comply with the standard.