search

justincred / pe

0 stars 0 forks source link

email accepts emails without .com #11

Open justincred opened 6 months ago

justincred commented 6 months ago

In the following example, the email without the .com after the @ is accepted image.png

nus-pe-script commented 6 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Email field accepts emails without a '.com'

As mentioned in the title, currently we can add users with emails that do not contain '.com', '.sg', etc. as there is only a validity check for 'local-part>@<domain'.

However, there are no emails that exist without this '.com', etc. (and many other websites check that the email follows this format '>@<.<>'.

This may result in confusion as the user may accidentally miss out the back half, and thus cannot be sure afterwards what is the current format at the end (since it may be .com, .com.sg, and so on)

image.png

I suggest that the validity check for the email format be extended to follow this format: '>@<.<>'

[original: nus-cs2103-AY2324S2/pe-interim#402] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your response, however, we must reject this bug report as "test@gmail" is a valid email address according to the standard for email address format.

You may refer to the standard for email addresses here: https://tools.ietf.org/html/rfc5322#section-3.4.1 however we understand it can be hard to read and there are many other supporting documents to follow.

You can also view these discussions and pages: https://stackoverflow.com/questions/20573488/why-does-html5-form-validation-allow-emails-without-a-dot https://stackoverflow.com/questions/27992870/should-email-validation-requires-the-domain-part-contains-a-dotjquery-validation/jquery-validation#2117 https://en.wikipedia.org/wiki/Email_address#Examples

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]