search

justincred / pe

0 stars 0 forks source link

Allowing of invalid dates #14

Open justincred opened 6 months ago

justincred commented 6 months ago

The deadline of the date has already passed as shown but it is still able to be in the input image.png

nus-se-script commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Deadlines in the past are accepted

As mentioned in the title, tasks can be added which have deadlines in the past. As these are tasks, it is unlikely that the user will every create a new task with a deadline that has already exceeded, and such situtations are more than likely to be typos.

To reproduce:

  1. addtask n/Task2 d/something p/1 by/18-02-1000 12:00

image.png

I suggest that deadlines before the current datetime are checked for and considered invalid

[original: nus-cs2103-AY2324S2/pe-interim#609] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As an attempt to maximize the flexibility of the app, we intentionally allowed users to add tasks with a past deadline, for documentation purposes, for example. Such deadlines are valid. It will be possible to add a warning to that a past date has been inputted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Completely disagree with this logic because your team implemented a priority system, and this will result in those tasks where deadlines have been passed to be shown at the very top as shown here which makes no sense especially if it is just for logging purposes ![image.png](https://raw.githubusercontent.com/justincred/pe/main/files/2c9939fa-7adc-400e-9fd6-32d88dc7faca.png)
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** This is a flaw with how your team implemented this feature as well as along side your priority system
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This is a very common issue for deadlines to have been passed and alongside the priority system, is going to be a very huge hindrance for users