justincred / pe

0 stars 0 forks source link

Error message can be more specific #17

Open justincred opened 7 months ago

justincred commented 7 months ago

Error message can show the exact integers to be accepted like in the UG, 123 as currently it shows integers giving the impression that any integers are allowed image.png

nus-pe-script commented 7 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message for invalid task priority is not very specific

As mentioned in the title, the error message for invalid task priorities (specifically for the integer values) is not very specific.

The error message mentions that the task priority can take either an integer value or ..., however, it does not specify that the integer value must be 1, 2 or 3. Technically, '4' is an Integer Value so the user may be confused when looking at the error message as it seems that the user did not enter a wrong command.

image.png

I suggest that the error message be made more specific to say that it will only take 1, 2 or 3, rather than implying that it takes all integer values.


[original: nus-cs2103-AY2324S2/pe-interim#404] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The error message being more specific has been specified in the future implementations under DG. Furthermore, this does not hinder the user very much if they follow the UG instructions.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This is referring to a different error message and your planned enhancements has to be specific enough and it does not include the above bug. This is because it refers to the person and task index while this is the priority index ![image.png](https://raw.githubusercontent.com/justincred/pe/main/files/431e289c-ce0b-4777-94b6-ed1d838775e6.png)