search

justincred / pe

0 stars 0 forks source link

Phone number overzealous input validation #7

Open justincred opened 4 months ago

justincred commented 4 months ago

Overzealous input validation as user might want to input 1234 5678 (HP) 1111-3333 (Office) but is unable to do so due to the current design, might want to lessen the strictness for phone inputs. image.png

soc-se-bot commented 4 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

International phone numbers

International phone numbers with country codes are not supported as well such as +62 as shown below

image.png

[original: nus-cs2103-AY2324S2/pe-interim#1182] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is possible for future implementation. At the moment we do not limit the length of phone number so one way to work around this is not adding the + sign to the number.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]