Closed justincy closed 5 years ago
justincy
commented
5 years ago I already found a flaw. It removed all child edges and nodes of 7: seven thunders; mystery of God finished even though some of the children are leaf nodes (i.e. the leaf nodes have no descendants of their own so there's nothing to simplify).
justincy
commented
5 years ago It's the cycle problem I was worried about. Because 7: seven thunders; mystery of God finished is in a cycle, all of its children are also deep descendants. Though I should be able to stop this by stopping deep descendant calculations when seeing the starting node.
justincy
commented
5 years ago I fixed that problem. Now it's removing 47:
Restoration -> Gathering of Israel
Restoration -> Times of the Gentiles fulfilled
Jews gathered in Jerusalem -> Christ comes in the clouds
Jews gathered in Jerusalem -> Two witnesses prophecy
All nations gathered against Israel -> Great earthquake
All nations gathered against Israel -> 7: seven thunders; mystery of God finished
All nations gathered against Israel -> Great hailstorm
All nations gathered against Israel -> Gog and Magog defeated
All nations gathered against Israel -> Heavens shake
All nations gathered against Israel -> Half of the city is captive
Sun darkened -> Sign of the Son of Man
Sun darkened -> Christ comes in the clouds
Sun darkened -> Angel sounds his trump
Moon turned to blood -> Christ comes in the clouds
Moon darkened -> Sign of the Son of Man
Moon darkened -> Christ comes in the clouds
Lord speaks from Zion and Jerusalem -> Burning
Heavens shake -> Christ comes in the clouds
Mount of Olives splits -> Christ reigns as King
Mount of Olives splits -> Great earthquake
Mount of Olives splits -> Christ comes in the clouds
Christ comes in the clouds -> Second trump: Redemption of Terrestrial spirits
Wars -> Christ comes in the clouds
Stars fall from heaven -> Christ comes in the clouds
Sign of the Son of Man -> Christ comes in the clouds
Signs in the heavens -> Christ comes in the clouds
Morning of the First Resurrection -> Second trump: Redemption of Terrestrial spirits
Opening of the Sixth Seal -> Great earthquake
Opening of the Sixth Seal -> Opening of the Seventh Seal
Opening of the Sixth Seal -> Curtain of heaven unfolded as a scroll
Opening of the Sixth Seal -> Sun darkened
Opening of the Sixth Seal -> Stars fall from heaven
Opening of the Sixth Seal -> Moon turned to blood
Sealing of the 144,000 -> Christ stands on Mount Zion
7: seven thunders; mystery of God finished -> Great earthquake
6: Euphrates dried up -> 7: seven thunders; mystery of God finished
Discovering of America -> Scattering of Lehi's seed
Scattering of Lehi's seed -> Fullness of the gospel preached to Lehi's seed
Mighty nation raised up -> Restoration
House of Israel scattered -> Restoration
Scattering of the Jews -> Jews gathered in Jerusalem
Burning -> Satan bound for 1000 years
New Jerusalem -> Christ stands on Mount Zion
Tares bound in bundles -> Burning
Gospel preached to the Gentiles -> Earthquakes
Curtain of heaven unfolded as a scroll -> Morning of the First Resurrection
Face of the Lord unveiled -> BurningIt's looking good. I don't see any problems. I'm going to look again tomorrow and then probably merge it.
Closes #6
The difference is enormous. It removed 50 lines:
I need to review it to see if it removed anything that should be kept. I know that the algorithm is weak when dealing with cycles. I protected against an infinite loop but it might remove an edge that really ought to stay.