justindressel / QuantumBayesian.jl

Julia package for simulating quantum evolution, including quantum Bayesian stochastic readout.
Other
13 stars 8 forks source link

Update Quantum.jl #6

Closed joseraulgonzalez closed 7 years ago

joseraulgonzalez commented 7 years ago

Modify Quantum.jl to handle complex operators properly. Previous version implicitly assigned real entries.

joseraulgonzalez commented 7 years ago

Some general comments:

  1. This patch fails to pass the tests with newer versions of Julia because QuantumBayesian.jl also fails. However, both the patch and QuantumBayesian.jl still work with v0.5 of Julia. Perhaps a new issue can be created to make changes to QuantumBayesian.jl that pass the tests for both older and newer versions of Julia.
  2. Maybe the tests for QauntumBayesian.jl can be modified to incorporate operators with non-trivial imaginary parts, and hence detect whether the change proposed here has no unintended ramifications.